fix: Fix masking in single element screenshots. #1825
Merged
+20
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Medartis AG" |
yury-s
reviewed
Aug 1, 2025
playwright/src/test/java/com/microsoft/playwright/TestPageScreenshot.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/ElementHandleImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/ElementHandleImpl.java
Outdated
Show resolved
Hide resolved
Using masks in single element screenshots (`Locator.screenshot()`) never worked, because the mask option failed to be serialized. Add a serializer for `LocatorImpl`, so that this works everywhere correctly. Fixes microsoft#1790
janne-hyoetylae-med
force-pushed
the
fix-locator-screenshot-mask
branch
from
85011e9 to
d85935a
Compare
yury-s
approved these changes
Aug 11, 2025
| @@ -146,6 +146,17 @@ void maskShouldWork() { | |||
| assertThrows(AssertionFailedError.class, () -> assertArrayEquals(screenshot, originalScreenshot)); | |||
| } | |||
|
|
|||
| @Test | |||
| void maskShouldWorkForLocator() { | |||
There was a problem hiding this comment.
note: We should have migrated more mask tests from upstream while adding the feature, it would help to avoid bugs like this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using masks in single element screenshots (
Locator.screenshot()) never worked, because the mask option failed to be serialized.When a mask is provided as an option, serialize it manually. This is the same implementation as in
PageImpl.screenshot().Fixes #1790